This repository has been archived by the owner on Dec 2, 2019. It is now read-only.
Non OpenGL SDL2 backend that uses SDL2_gfx #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's based on the old 1.2 backend as you can see in my commits. It doesn't clash with the other pull request/issue currently open (which is sdl_native) and the old SDL1.2 folder was sdl1.2_gfx not sdl_gfx so I think that's sufficient.
I could rename the folder sdl2_gfx or similar but that would be inconsistent/confusing since the opengl ones are sdl_openglX not sdl2_openglX even though they've always used SDl2.
Also I can create a new branch with a single commit if you prefer but I wanted to show the 1.2 to 2 porting process if people were interested.
Lastly, I also found an unrelated bug. If you define VARARGS the compile fails unless the user includes stdarg.h before including nuklear. This is because va_list is undefined but needed even in the header portion of nuklear.h unlike for STANDARD_IO etc. where they're only needed in the implementation.
I can fix that in a separate pull request or add it to this one. I think it's just adding stdarg.h here